Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add liquid nova service info endpoint #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add liquid nova service info endpoint #610

wants to merge 1 commit into from
+143 −4

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented Nov 22, 2024

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@Varsius Varsius marked this pull request as ready for review November 22, 2024 13:00
@coveralls
Copy link

Coverage Status

coverage: 79.005%. remained the same
when pulling b47ded3 on liquid-nova
into 9bdd8fb on master.

@Varsius
Copy link
Contributor Author

Varsius commented Nov 22, 2024

Should I test that the legacy nova plugin still works after the dependencies have been moved? If yes, how would I do this?

majewsky
majewsky reviewed Nov 22, 2024
View reviewed changes
docs/liquids/nova.md
Comment on lines +22 to +23
| `server_groups_members` | None | HasCapacity = false, HasQuota = true |
| `$FLAVOR_NAME` | None | HasCapacity = true, HasQuota = true |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the naming as before here:

Suggested change
| `server_groups_members` | None | HasCapacity = false, HasQuota = true |
| `$FLAVOR_NAME` | None | HasCapacity = true, HasQuota = true |
| `server_group_members` | None | HasCapacity = false, HasQuota = true |
| `instances_$FLAVOR_NAME` | None | HasCapacity = true, HasQuota = true |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varsius @coveralls @majewsky