liquids/cinder: fix capacity for volume types sharing the same backend name #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d name This diff is way more intrusive than I would have liked, but the basic structure is retained. Instead of drilling down into volume type and then into AZ, we need to drill down into volume backend name and AZ. Then at the lowest level, a single volume backend name can be shared by multiple volume types, so the reported capacity and usage need to be balanced by demand (in the same way as we do in liquid-manila between share capacity and snapshot capacity). This then gets bubbled back up all the way.
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
VoigtS
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff is way more intrusive than I would have liked, but the basic structure is retained. Instead of drilling down into volume type and then into AZ, we need to drill down into volume backend name and AZ.
Then at the lowest level, a single volume backend name can be shared by multiple volume types, so the reported capacity and usage need to be balanced by demand (in the same way as we do in liquid-manila between share capacity and snapshot capacity). This then gets bubbled back up all the way.
Checklist:
I updated the documentation to describe the semantical or interface changes I introduced.