remove support for Ironic in QuotaPlugins/CapacityPlugins #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
It is now only supported to use liquid-ironic for Ironic resources. - The FlavorAliases/FlavorTranslationTable feature is removed as it was a) never used and b) only intended for Ironic flavors. - The HypervisorTypeRules feature is removed because we only used this in practice to distinguish between hypervisor type `none` (for baremetal) or `vmware`. With Ironic removed, this can be replaced by a fixed string. - The FlavorNameSelection feature is reduced to a single regex which works out the same in practice. It is not necessary to have multiple regexes here anymore: This was used for category assignment of resources, but this has moved into ResourceBehavior now.
majewsky
force-pushed
the
remove-ironic-plugins
branch
from
d52a685 to
64eddea
Compare
|
@Varsius FYI - Please use this as a guide for what needs to be carried over into liquid-nova. |
VoigtS
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now only supported to use liquid-ironic for Ironic resources.
The FlavorAliases/FlavorTranslationTable feature is removed as it was a) never used and b) only intended for Ironic flavors.
The HypervisorTypeRules feature is removed because we only used this in practice to distinguish between hypervisor type
none(for baremetal) orvmware. With Ironic removed, this can be replaced by a fixed string.The FlavorNameSelection feature is reduced to a single regex which works out the same in practice. It is not necessary to have multiple regexes here anymore: This was used for category assignment of resources, but this has moved into ResourceBehavior now.