Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collector: add TaskTiming type #354

Merged
merged 1 commit into from
Sep 12, 2023
Merged

collector: add TaskTiming type #354

merged 1 commit into from
Sep 12, 2023

Conversation

majewsky
Copy link
Contributor

@majewsky majewsky commented Sep 12, 2023 •
edited
Loading

I want to reuse this in the capacity scrape.

Also, scrapeTask gets renamed to projectScrapeTask because I will be adding another type capacityScrapeTask next to it.

@coveralls
Copy link

coveralls commented Sep 12, 2023 •
edited
Loading

Coverage Status

coverage: 79.941%. remained the same when pulling ed2218a on scrape-code-reuse into 3df2619 on master.

@majewsky
collector: add TaskTiming type
ed2218a 
I want to reuse this in the capacity scrape.
@SuperSandro2000 SuperSandro2000 merged commit 5d77aa8 into master Sep 12, 2023
6 checks passed
@SuperSandro2000 SuperSandro2000 deleted the scrape-code-reuse branch September 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majewsky @coveralls @SuperSandro2000