Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter, fix loop references #967

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update linter, fix loop references #967

merged 1 commit into from
Dec 17, 2024
+4 −20

Conversation

jknipper
Copy link
Collaborator

As far as I understand behavior of references in loops is changed in golang>=1.22

@Nuckal777
Copy link
Contributor

I think our Dockerfile needs linter updates as well or the linter to be removed. 🤔

@jknipper
Copy link
Collaborator Author

I think our Dockerfile needs linter updates as well or the linter to be removed. 🤔

Which one do you mean? I only found it in the ones already included.

Nuckal777
Nuckal777 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Nuckal777 Nuckal777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentally skipped the dockerfile adjustments. :(

@jknipper jknipper merged commit 2a74e3a into master Dec 17, 2024
2 checks passed
@jknipper jknipper deleted the update_linter_1_62_2 branch December 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuckal777 Nuckal777 Nuckal777 approved these changes

@databus23 databus23 Awaiting requested review from databus23 databus23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jknipper @Nuckal777