Skip to content

Commit

Permalink
Disable OS updates during xmas (#968)
Browse files Browse the repository at this point in the history
* Disable OS updates during xmas

* Disable tests
  • Loading branch information
jknipper authored Dec 18, 2024
1 parent 2a74e3a commit 5b41e45
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
22 changes: 12 additions & 10 deletions pkg/controller/servicing/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,17 +341,19 @@ func TestServicingControllerReconcile(t *testing.T) {
}

_, err := controller.Reconcile(kluster)
if subject.expectedDrain {
mockCycler.AssertCalled(t, "Drain", nodes[0])
} else {
mockCycler.AssertNotCalled(t, "Drain")
}
/*
if subject.expectedDrain {
mockCycler.AssertCalled(t, "Drain", nodes[0])
} else {
mockCycler.AssertNotCalled(t, "Drain")
}
if subject.expectedReboot {
mockCycler.AssertCalled(t, "Reboot", nodes[0])
} else {
mockCycler.AssertNotCalled(t, "Reboot")
}
if subject.expectedReboot {
mockCycler.AssertCalled(t, "Reboot", nodes[0])
} else {
mockCycler.AssertNotCalled(t, "Reboot")
}
*/

if subject.expectedReplace {
mockCycler.AssertCalled(t, "Replace", nodes[0])
Expand Down
4 changes: 3 additions & 1 deletion pkg/controller/servicing/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (

"github.com/go-kit/log"
"github.com/pkg/errors"
core_v1 "k8s.io/api/core/v1"
"k8s.io/client-go/tools/record"

"github.com/sapcc/kubernikus/pkg/api/models"
Expand Down Expand Up @@ -157,7 +158,8 @@ func (r *KlusterReconciler) Do() error {

update := r.Lister.Updating()
replace := r.Lister.Replace()
reboot := r.Lister.Reboot()
// reboot := r.Lister.Reboot()
reboot := make([]*core_v1.Node, 0) // disable reboots for now

// The following block retires already updating nodes
if len(update) > 0 {
Expand Down

0 comments on commit 5b41e45

Please sign in to comment.