fix sublease token propagation during creation of managed replica accounts #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A classic case of stringly-typed interface: Because the return type on the callback was only string, we did not notice that we returned the full serialized token when we should only have been returning the contents of the
secret
field. To avoid this error, the callback now returns a structuredkeppel.SubleaseToken
value.Also, I changed the callback to return just
error
instead of*keppel.RegistryV2Error
. The latter is more consistent with whatCreateOrUpdateAccount
returns, but this change makes the callback implementations shorter, which overall helps readability.