-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keystone] support secret-injector #7472
Open
rajivmucheli
wants to merge
5
commits into
master
Choose a base branch
from
keystone_support_si
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent version bump we got a new helper in the `utils` chart that makes it possible to support `secrets-injector` secrets will still maintaining compatibility. This is also required for upcoming PCI audit and secret rotation..
rajivmucheli
requested review from
galkindmitrii,
Carthaca,
bbobrov,
fwiesel and
stanislav-zaprudskiy
as code owners
November 27, 2024 09:28
rajivmucheli
requested review from
s10
and removed request for
galkindmitrii,
fwiesel,
Carthaca,
stanislav-zaprudskiy and
bbobrov
November 27, 2024 09:30
fwiesel
approved these changes
Nov 27, 2024
galkindmitrii
approved these changes
Nov 27, 2024
fwiesel
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything that is an url needs resolve_secret_urlquery
instead of resolve_secret
fwiesel
reviewed
Nov 27, 2024
fwiesel
approved these changes
Nov 27, 2024
s10
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent version bump we got a new helper in the
utils
chart that makes it possible to supportsecrets-injector
secrets will still maintaining compatibility. This is also required for upcoming PCI audit and secret rotation..