[utils] add helper to resolve secrets that need urlquery function #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
galkindmitrii
commented
Apr 11, 2024
galkindmitrii
commented
- with a new secret-injector we cannot use urlquery over new secret vault references.
- with a new helper function we work around it by adding 'resolve' on the fly with optional urlquery at the end where it is needed.
- this patch also uses new helper for places where we had urlquery before. This would allow to simplify the values inside the secrets repo.
s10
force-pushed
the
add_utils_secret_resolver
branch
from
95433b3
to
7096cd4
Compare
- with a new secret-injector we cannot use urlquery over new secret vault references. - with a new helper function we work around it by adding 'resolve' on the fly with optional urlquery at the end where it is needed. - this patch also uses new helper for places where we had urlquery before. This would allow to simplify the values inside the secrets repo.
We do not want to depend on the `rabbitmq` chart to render our INI sections. Therefore, we introduce `ini_section._transport_url` and `utils.rabbitmq_url`. The first contains also the "transport_url = " part necessary for the INI. With `utils.rabbitmq_url` accepting a dict of parameters to render the actualy URL, we can also use it to generate Nova's cell2 and the auditmiddleware's URL instead of having to do that "manually". In addition, there's only a single place that adds the `resolve_secret_urlquery` part now.
Since we're going to use secret references instead of actual values, we need to rewrite them with our `resolve_secret` helper to resolve them.
s10
force-pushed
the
add_utils_secret_resolver
branch
from
7096cd4
to
a2ba0fd
Compare
s10
approved these changes
Aug 2, 2024
Carthaca
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.