Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAP] Added admins view all volume_admin_metadata #88

Draft
wants to merge 1 commit into
base: stable/train-m3
Choose a base branch
from

Commits on Mar 10, 2021

  1. [SAP] Added admins view all volume_admin_metadata

    This patch adds the ability for admins to view
    volume_admin_metadata when fetching volumes from the API.
    
    This patch ensures that ensure_export at init_host time can
    do a model update.
    
    referencing:
    https://review.opendev.org/c/openstack/cinder/+/779835
    
    This patch slightly refactors create_export, ensure_export and
    initialize_connection to allow saving a model_update back for each
    of those calls.
    
    The model update returns some vital information about the volume,
    the vcenter uuid, the datastore name, and the vcenter storage profile
    associated with that volume.  That information is stored in the
    volume_admin_metadata table as key/value pairs that are then returned
    (for admin users) when a volume list or show is called from the API.
    
    ensure_export is called for every in-use, available volume at cinder
    startup.  So existing volumes will get updated in the db at
    cinder startup.
    
    We will then be able to update the host entries later if/when we
    migrate to supporting datastores as pools.  Each volume will need
    to get updated to change its host entry to include the pool name
    (datastore name) as part of the host entry, so cinder knows which
    cinder-volume service instance manages that specific volume.
    hemna committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    926cdfd View commit details
    Browse the repository at this point in the history