Revert "improve omitFirstPage"

This reverts commit dfe64b7. Fixes #158
sampart · Nov 30, 2017 · a252e1d · a252e1d
1 parent 5fd47a5
commit a252e1d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Twig/PagerfantaExtension.php b/Twig/PagerfantaExtension.php
@@ -140,8 +140,9 @@ private function createRouteGenerator($options = array())
 
         return function($page) use($router, $routeName, $routeParams, $pagePropertyPath, $omitFirstPage) {
             $propertyAccessor = PropertyAccess::createPropertyAccessor();
-            // don't set the page parameter if it is the first page and the omitFirstPage flag is true
-            if(!$omitFirstPage || $page > 1 ){
+            if($omitFirstPage){
+                $propertyAccessor->setValue($routeParams, $pagePropertyPath, $page > 1 ? $page : null);
+            } else {
                 $propertyAccessor->setValue($routeParams, $pagePropertyPath, $page);
             }