Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few quality of life fixes for the previous pull #1362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A few quality of life fixes for the previous pull #1362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d9676d
Comment fix for documentation and changed function names
lucifgy Oct 8, 2023
9a7cb8a
Corrected async functions for the previous commit
lucifgy Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions binance/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3452,7 +3452,7 @@ def get_all_isolated_margin_symbols(self, **params):
"""
return self._request_margin_api('get', 'margin/isolated/allPairs', signed=True, data=params)

def isolated_margin_fee_data(self, **params):
def get_isolated_margin_fee_data(self, **params):
"""Get isolated margin fee data collection with any vip level or user's current specific data as https://www.binance.com/en/margin-fee

https://binance-docs.github.io/apidocs/spot/en/#query-isolated-margin-fee-data-user_data
Expand All @@ -3461,11 +3461,10 @@ def isolated_margin_fee_data(self, **params):
:type vipLevel: int
:param symbol: optional
:type symbol: str
:param recvWindow: optional: No more tahn 60000
:type recvWindow: long

:returns: API response

.. code-block:: python
[
{
"vipLevel": 0,
Expand All @@ -3488,8 +3487,8 @@ def isolated_margin_fee_data(self, **params):
"""
return self._request_margin_api('get', 'margin/isolatedMarginData', True, data=params)

def isolated_margin_tier_data(self, **params):
"""
def get_isolated_margin_tier_data(self, **params):
"""Get isolated margin tier data collection with any tier as https://www.binance.com/en/margin-data

https://binance-docs.github.io/apidocs/spot/en/#query-isolated-margin-tier-data-user_data

Expand All @@ -3501,7 +3500,8 @@ def isolated_margin_tier_data(self, **params):
:type recvWindow:

:returns: API response


.. code-block:: python
[
{
"symbol": "BTCUSDT",
Expand Down Expand Up @@ -8825,13 +8825,13 @@ async def get_all_isolated_margin_symbols(self, **params):
return await self._request_margin_api('get', 'margin/isolated/allPairs', signed=True, data=params)
get_all_isolated_margin_symbols.__doc__ = Client.get_all_isolated_margin_symbols.__doc__

async def isolated_margin_fee_data(self, **params):
async def get_isolated_margin_fee_data(self, **params):
return await self._request_margin_api('get', 'margin/isolatedMarginData', True, data=params)
isolated_margin_fee_data.__doc__ = Client.isolated_margin_fee_data.__doc__
get_isolated_margin_fee_data.__doc__ = Client.get_isolated_margin_fee_data.__doc__

async def isolated_margin_tier_data(self, **params):
async def get_isolated_margin_tier_data(self, **params):
return await self._request_margin_api('get', 'margin/isolatedMarginTier', True, data=params)
isolated_margin_tier_data.__doc__ = Client.isolated_margin_tier_data.__doc__
get_isolated_margin_tier_data.__doc__ = Client.get_isolated_margin_tier_data.__doc__

async def toggle_bnb_burn_spot_margin(self, **params):
return await self._request_margin_api('post', 'bnbBurn', signed=True, data=params)
Expand Down