Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old Select components with new one #5027

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 5, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Two things that have been change and look a little bit different now:

  1. Tax settings card for channels
    Before:
Screenshot 2024-07-08 at 16 27 22 After: Screenshot 2024-07-08 at 16 26 48
  1. Edit order shipping methods
    Before:
Screenshot 2024-07-08 at 16 27 43

After:
Screenshot 2024-07-08 at 16 27 11

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: b300edf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 07:53 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 09:48 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 11:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 12:28 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 12:44 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 14:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 5, 2024 17:19 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 10:03 Destroyed
andrzejewsky
andrzejewsky previously approved these changes Jul 8, 2024
Droniu
Droniu previously approved these changes Jul 8, 2024
src/components/TextWithSelectField/TextWithSelectField.tsx Outdated Show resolved Hide resolved
@poulch poulch dismissed stale reviews from Droniu and andrzejewsky via 659edeb July 8, 2024 11:29
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 11:31 Destroyed
@yellowee yellowee self-requested a review July 8, 2024 11:43
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 11:44 Destroyed
yellowee
yellowee previously approved these changes Jul 8, 2024
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 12:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 13:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 15:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 15:21 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5027 July 8, 2024 17:13 Destroyed
yellowee
yellowee previously approved these changes Jul 9, 2024
@github-actions github-actions bot temporarily deployed to pr-5027 July 9, 2024 11:45 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants