SAK-50284 Kernel email Message-ID must contain angle brackets #12720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusmmp
reviewed
Jul 9, 2024
| protected void updateMessageID() throws MessagingException | ||
| */ | ||
| @Override | ||
| protected void updateMessageID() throws MessagingException |
jesusmmp
reviewed
Jul 9, 2024
| } | ||
|
|
||
| protected void updateHeaders() throws MessagingException | ||
| @Override | ||
| protected void updateHeaders() throws MessagingException |
jesusmmp
reviewed
Jul 9, 2024
| { | ||
| log.error("Email.MyMessage: exception: " + e, e); | ||
| log.error("Email.MyMessage: exception: {}", e, e); |
jesusmmp
reviewed
Jul 9, 2024
| @@ -1692,7 +1688,6 @@ public String propName(String propNameTemplate) | |||
|
|
|||
| public String propName(String propNameTemplate, String protocol) | |||
| { | |||
| String formattedName = String.format(propNameTemplate, protocol); | |||
| return formattedName; | |||
| return String.format(propNameTemplate, protocol); | |||
ern
changed the title
ern
reviewed
Jul 18, 2024
kernel/kernel-impl/src/main/java/org/sakaiproject/email/impl/BasicEmailService.java
Outdated
Show resolved
Hide resolved
ern
approved these changes
Jul 18, 2024
adrianfish
reviewed
Jul 19, 2024
kernel/kernel-impl/src/main/java/org/sakaiproject/email/impl/BasicEmailService.java
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Jul 19, 2024
kernel/kernel-impl/src/main/java/org/sakaiproject/email/impl/BasicEmailService.java
Outdated
Show resolved
Hide resolved
…asicEmailService.java
…asicEmailService.java
ern
pushed a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Earle Nietzel <[email protected]> Co-authored-by: Adrian Fish <[email protected]> (cherry picked from commit 5bf0159)
ern
pushed a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Earle Nietzel <[email protected]> Co-authored-by: Adrian Fish <[email protected]> (cherry picked from commit 5bf0159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.