Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added general templates support #74

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

tasn
Copy link

@tasn tasn commented Feb 21, 2014

This lets you define general templates instead of forcing index.html. This is useful for generating atom, rss, and generally not having index.html.

tasn added 4 commits February 21, 2014 22:48
This splits all the theme handling logic to a different file,
so it can be reused.
We should use the actual template_file used, not assume index.html.
This is very useful for generating atom feeds, differently named files
and etc.
@saimn
Copy link
Owner

saimn commented Mar 3, 2014

Hi @tasn ,

If I understand correctly, the idea is to generate html files for every html template found in the theme directory. Could you provide an example of how it could be used ? I don't see how you use it to generate a RSS feed: one RSS feed per album, based on the EXIF date ?

Also I would prefer not adding a whole theme in the tests sample, just to test this feature. The css/js/image files are not needed for the tests.

I have started working on a big refactoring on the storage of album and media informations, I will try to finalize this soon. It will maybe require some updates on your side, I will ping you once it is ready.

@tasn
Copy link
Author

tasn commented Mar 4, 2014

Jinja templates are not just for html files, this essentially changes it to work on all of the files found, html or not. This let's you do rss by simple having a template with content that contains the rss format, just like you would with html.

As for the tests: point taken, will do.

I'd love it if you could update my pull request on the way, as you know best what changes are needed. Anyhow, my changes are quite surgical.

I'll try to make the changes as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants