-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status bar isHidden not right in viewWillAppear #164
base: master
Are you sure you want to change the base?
Conversation
Reviewed 2 of 2 files at r1. MobilePlayer/MobilePlayerViewController.swift, line 159 at r1 (raw file):
Could you separate this line change to a different branch and send another pull request? MobilePlayer/MobilePlayerViewController.swift, line 232 at r1 (raw file):
Hiding the status bar in viewDidLoad while its state is being restored when the view disappears will cause issues in certain use cases. Could you check the latest master and let me know if you still have problems with the status bar? MobilePlayer/Views/Slider.swift, line 18 at r1 (raw file):
Could you separate the changes related to the slider to a different branch and send another pull request? Also, it'd be great if you could put the definition of LargeTouchAreaUIView in a new file. Comments from Reviewable |
…-ios * 'master' of https://github.com/mobileplayer/mobileplayer-ios: changed visibility of showContentActions from public to open to enable override Fix StatusBar is modified by MPMoviePlayerViewController
* originalFix: 添加dismiss事件, 适配iphoneX
test on iOS 10.2
This change is