Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status bar isHidden not right in viewWillAppear #164

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sandyway
Copy link

@sandyway sandyway commented Jan 23, 2017

test on iOS 10.2


This change is Reviewable

@isair
Copy link
Contributor

isair commented May 9, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


MobilePlayer/MobilePlayerViewController.swift, line 159 at r1 (raw file):

            NotificationCenter.default.post(name: NSNotification.Name(rawValue: MobilePlayerDidEncounterErrorNotification), object: self, userInfo: [MobilePlayerErrorUserInfoKey: error])
        }
        if let postrollVC = slf.postrollViewController, !slf.isBeingDismissed {

Could you separate this line change to a different branch and send another pull request?


MobilePlayer/MobilePlayerViewController.swift, line 232 at r1 (raw file):

    
    // Force hide status bar.
    previousStatusBarHiddenValue = UIApplication.shared.isStatusBarHidden

Hiding the status bar in viewDidLoad while its state is being restored when the view disappears will cause issues in certain use cases.

Could you check the latest master and let me know if you still have problems with the status bar?


MobilePlayer/Views/Slider.swift, line 18 at r1 (raw file):

}

class LargeTouchAreaUIView: UIView {

Could you separate the changes related to the slider to a different branch and send another pull request? Also, it'd be great if you could put the definition of LargeTouchAreaUIView in a new file.


Comments from Reviewable

sandyway and others added 6 commits June 15, 2017 10:21
…-ios

* 'master' of https://github.com/mobileplayer/mobileplayer-ios:
  changed visibility of showContentActions from public to open to enable override
  Fix StatusBar is modified by MPMoviePlayerViewController
* originalFix:
  添加dismiss事件, 适配iphoneX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants