Implemented NumPy backend for Component class #38325
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmoon
force-pushed
the
feature/numpy_backend
branch
4 times, most recently
from
c2d1744
to
2c5bcee
Compare
amanmoon
force-pushed
the
feature/numpy_backend
branch
from
2c5bcee
to
6da102c
Compare
amanmoon
force-pushed
the
feature/numpy_backend
branch
from
6da102c
to
d56d730
Compare
amanmoon
force-pushed
the
feature/numpy_backend
branch
from
d56d730
to
834ef46
Compare
mkoeppe
reviewed
Jul 11, 2024
mkoeppe
reviewed
Jul 11, 2024
mkoeppe
reviewed
Jul 12, 2024
| @@ -0,0 +1,993 @@ | |||
| # Tensor Component Backend using numpy.ndarray | |||
There was a problem hiding this comment.
Please add standard file header (comment and copyright comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new backend for the
Componentclass usingNumPy.The ComponentNumpy class is created keeping the expansion of sage.tensor to multi-dimensional array in mind.
The changes align with the
Python array APIstandards.Summary of changes:
The
ComponentNumpyclass has a new added parameterself._shape.The previous
self._frameandself._sindexparameters have been converted to a tuple to house multiple frames and start index in order of dimension.The
self._compparameter is initialized to numpy.ndarray with all values as zero.Fixes #30308
#38248
@mkoeppe
📝 Checklist