Adding TikTok Filters #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added list of tested URL's - Some subdomains (business.tiktok.com) were required, blocking the root domain wasn't working - Includes CDN's - Includes alternative services (Douyin, Musically, etc.)
|
@dhaavi I like the idea of the tiktok list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
wwwbecause it was not working on my end without that. (I can edit that out if needed).The Why:
TikTok and related services were not getting blocked until manually adding these URL's in
Global Settings->Rules->Outgoing Rules.Definitely more URL's that could be added, saw this list mentioned in #59, but wanted to keep things relatively simple.
If this is the wrong file location, or if there's a better way to implement, feel free to let me know.