Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignettes: Code refactoring and Figure enhancements. #134

Merged
merged 8 commits into from
Oct 19, 2024

Conversation

enblacar
Copy link
Contributor

Hi!

I am a very big fan of decoupleR and I use it as an integral part of my analyses both for single cell and bulk transcriptomics data. For this, I have been thinking for a while in ways I could help enhancing this great R package.

I noted that the vignettes could use some improvement and, if you agree with it, I would like to propose the following changes:

  • All the code has been styled so that it stays within the span of the code blocks as much as possible, since code folding is not enabled in the website. Perhaps reducing the font size of the code blocks would be an option for the website.
  • Added the source packages to each function, so that group_by now becomes dplyr::group_by. This helps the user get a better overview of where each function originated from.
  • Added a different Red-Blue color palette to the plots that I find more aesthetic.
  • Enforced squared tiles in all heatmaps so that they become perfect squares, and added white borders around for enhanced aesthetics.
  • Added a black border around the cells in the volcano-like plots, to make them more aesthetic.

Suggestions for further improvement:

  • Add more theming to the DimPlot and FeaturePlot figures in the single-cell vignettes, perhaps with the use of single-cell visualization packages such as SCpubr.

While I have tested the output of the vignettes with knitr, this does not incorporate further CSS theming. For this, I believe you have to test it on your end.

Let me know if this was helpful, and I am very happy to apply any other changes to this PR as per your request!

Best,
Enrique

@PauBadiaM PauBadiaM self-requested a review July 22, 2024 10:46
@PauBadiaM PauBadiaM merged commit f916a46 into saezlab:master Oct 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants