Vignettes: Code refactoring and Figure enhancements. #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am a very big fan of
decoupleR
and I use it as an integral part of my analyses both for single cell and bulk transcriptomics data. For this, I have been thinking for a while in ways I could help enhancing this great R package.I noted that the vignettes could use some improvement and, if you agree with it, I would like to propose the following changes:
group_by
now becomesdplyr::group_by
. This helps the user get a better overview of where each function originated from.Red-Blue
color palette to the plots that I find more aesthetic.Suggestions for further improvement:
DimPlot
andFeaturePlot
figures in the single-cell vignettes, perhaps with the use of single-cell visualization packages such asSCpubr
.While I have tested the output of the vignettes with
knitr
, this does not incorporate furtherCSS
theming. For this, I believe you have to test it on your end.Let me know if this was helpful, and I am very happy to apply any other changes to this PR as per your request!
Best,
Enrique