Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS icon #1762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

skoch13
Copy link

@skoch13 skoch13 commented Dec 18, 2024

Description

Updates the CSS icon as per https://github.com/CSS-Next/logo.css.

Generated small version for improved readability as icon as suggested here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: CC0-1.0 license

Copy link
Contributor

@realguse realguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

Thanks for the PR!

I am just wondering, because the old icon is so unspecific, if people use it to get a fat # unrelated to css. Like a This is a root shell, because root at least in former times had a # instead of a $ to warn users 🤔 But then, maybe that concept is too old.

So in principle maybe it is better to add the new css logo instead of replacing the old seti one?

Screenshot 2024-12-22 at 11 09 01

Some random mention of the use of # for root shells:

Screenshot 2024-12-22 at 11 14 38

@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

Note to self: The svg needs some manual cleanup
(Don't worry with that, I will just do it before pull)

Screenshot 2024-12-22 at 11 24 10

@skoch13
Copy link
Author

skoch13 commented Dec 22, 2024

@Finii thank you for your suggestions!
I’m wondering if those who know what hashtag stands for in say bash will ever use css icon to represent it 😀

That being said I’m 100% positive not breaking existing workflows. Will placing it in the very same folder with the css_new.svg name address this?

@skoch13
Copy link
Author

skoch13 commented Dec 22, 2024

The svg needs some manual cleanup

I was thinking about this myself, but decided not to touch it prematurely. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants