Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for big-endian architectures #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ooichu
Copy link

@ooichu ooichu commented Feb 4, 2023

Big-endian compatibility tested with qemu-mips

Big-endian compatibility tested with `qemu-mips`
doc/impl.md Outdated
* The storage of an object's type and GC mark assumes a little-endian system and
will not work correctly on systems of other endianness
* The storage of an object's type and GC mark assumes a little-endian or
big-endian system and will not work correctly on systems of other endianness
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"other endianness"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have heard that there is mixed-endian (not bi-endian), but I don't even know where it is actually used. So I'm not sure if the issue is completely solved.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, mixed-endian is rather academic
https://en.wikipedia.org/wiki/Endianness#Middle-endian

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a new phobia: the obsessive feeling that there is a third byte order somewhere.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I made a big endian PowerPC port http://aminet.net/package/dev/lang/fe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From personal experience, I realized that it is very inconvenient to check every time you need #define FE_BIGENDIAN. So, I made an automatic endian check. If you consider it necessary, you can update your port.

@ooichu ooichu changed the title Add optional support for big-endian architectures Add support for big-endian architectures Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants