Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially Revert "Switch to shell: true for spawing git. (#4)" #7

Closed
wants to merge 1 commit into from
Closed

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 4, 2019

This partially reverts commit 51ad38d.

WIP until we figure out how to proceed.

@rvagg
Copy link
Owner

rvagg commented Oct 14, 2019

WIP? can we get something definitive on this?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 14, 2019

@rvagg see my comment on nodejs/changelog-maker#66

If we get changelog maker to work on Windows, we don't need to revert this.

@rvagg rvagg closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants