Skip to content

Commit

Permalink
fix: Add more usable fieldtypes to group by (frappe#22497)
Browse files Browse the repository at this point in the history
- Autocomplete is same as select
- Dynamic link is same as link
- Date is useful too

Possible improvement `group by date(datetime)` (not part of this PR)
  • Loading branch information
ankush authored Sep 21, 2023
1 parent 41d30e7 commit 4888e85
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion frappe/public/js/frappe/ui/group_by/group_by.js
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,16 @@ frappe.ui.GroupBy = class {
this.all_fields = {};

const fields = this.report_view.meta.fields.filter((f) =>
["Select", "Link", "Data", "Int", "Check"].includes(f.fieldtype)
[
"Select",
"Link",
"Data",
"Int",
"Check",
"Dynamic Link",
"Autocomplete",
"Date",
].includes(f.fieldtype)
);
const tag_field = { fieldname: "_user_tags", fieldtype: "Data", label: __("Tags") };
this.group_by_fields[this.doctype] = fields
Expand Down

0 comments on commit 4888e85

Please sign in to comment.