Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more Gecko-internal enums/dicts from WebIDL #3723

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Remove more Gecko-internal enums/dicts from WebIDL #3723

merged 3 commits into from
Nov 27, 2023

Conversation

evilpie
Copy link
Contributor

@evilpie evilpie commented Nov 26, 2023

No description provided.

@evilpie evilpie marked this pull request as draft November 26, 2023 13:38
@evilpie evilpie marked this pull request as ready for review November 26, 2023 14:26
daxpedda
daxpedda requested changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!
Could you add a note in the changelog as well?

@evilpie evilpie marked this pull request as draft November 27, 2023 16:50
@evilpie evilpie marked this pull request as ready for review November 27, 2023 16:57
daxpedda
daxpedda approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 8ec687e into rustwasm:main Nov 27, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evilpie @daxpedda