Prioritized Task Scheduling API #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
prioritized-task-scheduling-api
branch
from
1a678f1
to
d9d2a64
Compare
daxpedda
force-pushed
the
prioritized-task-scheduling-api
branch
from
d9d2a64
to
1465947
Compare
Liamolucko
reviewed
Aug 25, 2023
| interface TaskController : AbortController { | ||
| constructor(optional TaskControllerInit init = {}); | ||
|
|
||
| undefined setPriority(TaskPriority priority); |
There was a problem hiding this comment.
I probably should have mentioned this before you merged, but I think this needs to be annotated with [Throws]. I'm not sure why it isn't in Firefox, but the spec says it's supposed to throw if it gets called reentrantly (i.e. inside a prioritychange handler).
There was a problem hiding this comment.
My bad, should have waited longer, gonna make a fix momentarily.
There was a problem hiding this comment.
Thanks for catching that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements two proposals:
Currently only enabled by default in Chromium even though they are in a very early stage of the W3C standardization process.
See:
MDN
Prioritized Task Scheduling draft (Firefox WebIDL)
Early detection of input events draft (Firefox WebIDL)