Two small breaking API changes before next release #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rustls_server_connection_get_server_name()` API function previously wrote the SNI value to a caller-provided buffer as it predates the `rustls_str` pattern. This commit updates it to return a `rustls_str`. Invalid parameters or incomplete connection state are returned as empty strs. The documented lifetime matches that of other `rustls_connection` accessors based on a "set-once" property we assume from upstream.
Previously `rustls_server_config_builder_set_persistence()` returned a `rustls_result` just to indicate if a required parameter was `NULL`. Our API guidelines instead recommend this function do nothing and return void for these circumstances.
14 tasks
This one should be pretty easy to review if you folks have a few min to spare. Thanks! |
ctz
approved these changes
Dec 31, 2024
|
These feels small enough to merge with 1 review. Thanks for taking a look ctz 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knocking out a couple small issues labelled
next-major-releasesince we're preparing a 0.15 inmain. Sure do appreciate havinglet .. elsestable in our MSRV 💞Resolves #179
Resolves #229
server: SNI rustls_connection getter ret rustls_str
The
rustls_server_connection_get_server_name()API function previously wrote the SNI value to a caller-provided buffer as it predates therustls_strpattern.This commit updates it to return a
rustls_str. Invalid parameters or incomplete connection state are returned as empty strs.The documented lifetime matches that of other
rustls_connectionaccessors based on a "set-once" property we assume from upstream.server: remove rustls_result from set_persistence
Previously
rustls_server_config_builder_set_persistence()returned arustls_resultjust to indicate if a required parameter wasNULL.Our API guidelines instead recommend this function do nothing and return void for these circumstances.