Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper v1 compatibility #234

Closed
Tracked by #127
Colerar opened this issue Nov 27, 2023 · 12 comments
Closed
Tracked by #127

Hyper v1 compatibility #234

Colerar opened this issue Nov 27, 2023 · 12 comments

Comments

@Colerar
Copy link

Colerar commented Nov 27, 2023

Hyper v1 removed hyper::Client and move it to hyper-util, called client::legacy::Client.

What is the future of this crate? Is there any roadmap?

@cpu
Copy link
Member

cpu commented Nov 27, 2023

There's a WIP PR updating to Hyper v1 on the go: #232

I don't think it will be prioritized until the work preparing Rustls 0.22 is complete. The existing version based on the pre-v1 Hyper is still maintained.

@djc
Copy link
Member

djc commented Nov 28, 2023

Personally, getting a hyper-rustls out with hyper 1 is a fairly high priority for me. When I worked on it a bit over a week ago, however, there was no hyper-util library yet so porting hyper-rustls wasn't really feasible. I intend to take a look at the open PR and remaining issues soon.

@kurtbuilds
Copy link

Is there already a branch in progress to complete this?

I took a stab at this but got lost. The https://hyper.rs/guides/1/upgrading/ upgrade guide unfortunately doesn't discuss the internals that this library seems to touch (Accept and so on). I'd be happy to take another swing if I could get some guidance.

@Arnavion
Copy link

#232

@nicolaspernoud
Copy link

There seems to be a fork here : https://github.com/Gelbpunkt/hyper-rustls/tree/hyper-v1 ...

@nicolaspernoud
Copy link

no, not yet : it seems to be a work in progress.

@djc
Copy link
Member

djc commented Jan 11, 2024

That's actually a PR against this project: #232. Looks like it should be merged and released soon.

@nicolaspernoud
Copy link

Good news ! Thanks !

@cpu
Copy link
Member

cpu commented Jan 12, 2024

0.26.0 with Hyper 1.0 support has been published.

@cpu cpu closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@djc @cpu @Arnavion @nicolaspernoud @Colerar @kurtbuilds and others