Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.26 release, update to Hyper 1.0 #250

Closed
cpu opened this issue Jan 11, 2024 · 8 comments
Closed

Prepare v0.26 release, update to Hyper 1.0 #250

cpu opened this issue Jan 11, 2024 · 8 comments
Assignees

Comments

@cpu
Copy link
Member

cpu commented Jan 11, 2024

This issue collects up preparation work for a hyper-rustls 0.26 release, bringing in the update to Hyper 1.0

Since main has already had its Cargo.toml version updated this is an issue instead of a pull-request.

Resolves #234

Proposed Release Notes

  • The hyper crate dependency has been updated to 1.0. hyper-rustls now uses the new hyper-util crate to replace functionality removed from hyper.
  • The Acceptor API has been removed and relevant examples updated. Hyper 1.0 has library consumers handle binding sockets and accepting connections themselves, removing the need for the Acceptor API. See examples/server.rs for an up to date example for accepting connections.
  • The tokio-runtime feature has been removed - hyper-rustls depends on hyper-util, and the tokio feature in hyper-util is required for the necessary IO adapter traits. Tokio was already a hard dependency of this crate.
@cpu
Copy link
Member Author

cpu commented Jan 11, 2024

@djc @ctz @Gelbpunkt Do these proposed release notes look good to you? I can publish a release once there are +1's for the proposed notes.

@Gelbpunkt
Copy link
Contributor

The release notes look good to me!

@ctz
Copy link
Member

ctz commented Jan 11, 2024

Looks good to me too!

@devsnek
Copy link

devsnek commented Jan 11, 2024

@cpu fyi looking at recent signed commits it seems your gpg keys might need to be updated

@Gelbpunkt
Copy link
Contributor

@cpu fyi looking at recent signed commits it seems your gpg keys might need to be updated

I think the "Unverified" is because I require commits authored by me to be signed with my key and even though I sign them on my branches, the signature is lost when using "squash and rebase" in the Github merge options. No key has expired.

@cpu
Copy link
Member Author

cpu commented Jan 11, 2024

I'm seeing my signature subkey showing an expiry of 2024-03-10. I concur with @Gelbpunkt that this is an artifact of merge commits and GitHub's UI. I regularly see my commits showing as "unverified" when merged by others so I've disabled vigilant mode in my account settings. I don't really believe its a useful practice with the current state of GitHub.

@djc
Copy link
Member

djc commented Jan 12, 2024

LGTM.

@cpu
Copy link
Member Author

cpu commented Jan 12, 2024

@cpu cpu closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants