-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable enc2 #65
Open
flier
wants to merge
9
commits into
rust-xed:master
Choose a base branch
from
flier:enc2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enable enc2 #65
+156
−25
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd20ab2 - Browse repository at this point
Copy the full SHA bd20ab2View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7e0e5a7 - Browse repository at this point
Copy the full SHA 7e0e5a7View commit details
Commits on Feb 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48733b5 - Browse repository at this point
Copy the full SHA 48733b5View commit details -
Add a
dylib
feature to allow linking xed dynamicallyWhen linking statically it is not possible to link both enc2 libraries. However, once they are compiled as dynamic libraries then linking both just works.
Configuration menu - View commit details
-
Copy full SHA for 646ac21 - Browse repository at this point
Copy the full SHA 646ac21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29be773 - Browse repository at this point
Copy the full SHA 29be773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b2b98d - Browse repository at this point
Copy the full SHA 0b2b98dView commit details -
Also add the bin dir to the search path on windows
You need this in order for rustc to correctly set the path so that includes the xed DLLs.
Configuration menu - View commit details
-
Copy full SHA for b5cfb28 - Browse repository at this point
Copy the full SHA b5cfb28View commit details -
Disable the --all-features test for windows
There is link issue when dylib and the enc2-chk libraries are linked that results in missing symbol warnings. This doesn't seem like something to fix in the current PR
Configuration menu - View commit details
-
Copy full SHA for 8504646 - Browse repository at this point
Copy the full SHA 8504646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a302a - Browse repository at this point
Copy the full SHA 80a302aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.