ndk/media_format: Implement Debug in terms of Display
#450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
media-format-debug
branch
2 times, most recently
from
28de788 to
4218769
Compare
Currently `Debug` only prints a raw pointer which is rather useless to look at. In addition to the pointer, also print the `Display` representation of `MediaFormat` which uses Android's `toString()` function to create a human-readable string of the various fields set inside of it. On a side-note it is "great" to see that `toString()` is not currently available as a user function via a lifetimed `CStr` as it is invalidated in a nontrivial way (e.g. when `toString()` is called again, and possibly also when `set_()` functions are called which are not currently borrowing it mutably).
MarijnS95
force-pushed
the
media-format-debug
branch
from
4218769 to
f620e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @zarik5 @spencercw
Currently
Debugonly prints a raw pointer which is rather useless to look at. In addition to the pointer, also print theDisplayrepresentation ofMediaFormatwhich uses Android'stoString()function to create a human-readable string of the various fields set inside of it.On a side-note it is "great" to see that
toString()is not currently available as a user function via a lifetimedCStras it is invalidated in a nontrivial way (e.g. whentoString()is called again, and possibly also whenset_()functions are called which are not currently borrowing it mutably).