ndk: Add DataSpace type and fns on Bitmap and NativeWindow
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I ran into various upstream doc issues while porting them to Rust: android/ndk#1933 Will have to do another pass based on upstream fixes. |
The `DataSpace` type represents typical named color spaces, where each value is a bitmask comprising of a standard, transfer function, and range value. All are implemented as `enum`s with `TryFromPrimitive` to make it obvious to see and handle unknown values, and include `#[non_exhaustive]` to allow us to bind new values in future non-breaking patch releases.
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Oct 14, 2023
Map the new compression functions that are available in API level 30, which also take a `DataSpace` that has recently been added in rust-mobile#438. Also turn `BitmapError` into a proper `non_exhaustive` `enum` with `num_enum`'s `catch_all` parser, similar to `MediaError`.
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Oct 14, 2023
Map the new compression functions that are available in API level 30, which also take a `DataSpace` that has recently been added in rust-mobile#438. Also turn `BitmapError` into a proper `non_exhaustive` `enum` with `num_enum`'s `catch_all` parser, similar to `MediaError`.
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Oct 14, 2023
Map the new compression functions that are available in API level 30, which also take a `DataSpace` that has recently been added in rust-mobile#438. Also turn `BitmapError` into a proper `non_exhaustive` `enum` with `num_enum`'s `catch_all` parser, similar to `MediaError`.
MarijnS95
added a commit
that referenced
this pull request
Oct 14, 2023
Map the new compression functions that are available in API level 30, which also take a `DataSpace` that has recently been added in #438. Also turn `BitmapError` into a proper `non_exhaustive` `enum` with `num_enum`'s `catch_all` parser, similar to `MediaError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DataSpacetype represents typical named color spaces, where each value is a bitmask comprising of a standard, transfer function, and range value. All are implemented asenums withTryFromPrimitiveto make it obvious to see and handle unknown values, and include#[non_exhaustive]to allow us to bind new values in future non-breaking patch releases.