Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming symlinks on Windows #134786

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Dec 26, 2024

Previously we only detected mount points and not other types of links when determining reparse point behaviour.

Also added some tests to avoid this regressing again in the future.

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 26, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea with read_link, r=me with the nit and a squash.

library/std/src/fs/tests.rs Outdated Show resolved Hide resolved
Previously we only detected mount points and not other types of links when determining reparse point behaviour.
@ChrisDenton
Copy link
Member Author

@bors r=tgross35

@bors
Copy link
Contributor

bors commented Dec 27, 2024

📌 Commit 54b130a has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2024
@bors
Copy link
Contributor

bors commented Dec 27, 2024

⌛ Testing commit 54b130a with merge 42591a4...

@bors
Copy link
Contributor

bors commented Dec 27, 2024

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 42591a4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 27, 2024
@bors bors merged commit 42591a4 into rust-lang:master Dec 27, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 27, 2024
@ChrisDenton ChrisDenton deleted the fix-rename-symlink branch December 27, 2024 13:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (42591a4): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
-0.1% [-0.2%, -0.1%] 3
Improvements ✅
(secondary)
-0.2% [-0.4%, -0.1%] 8
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 3

Max RSS (memory usage)

Results (primary -1.1%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
2.1% [1.7%, 2.6%] 4
Improvements ✅
(primary)
-2.4% [-2.5%, -2.2%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-2.5%, 1.3%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.9s -> 765.869s (0.26%)
Artifact size: 330.55 MiB -> 330.63 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants