Consider arm to diverge if guard diverges #134735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Dec 24, 2024
| self.check_expr_has_type_or_error(e, tcx.types.bool, |_| {}); | ||
|
|
||
| // FIXME: If this is the first arm and the pattern is irrefutable, |
There was a problem hiding this comment.
This would be the place to insert a fix for #134734 (it'll need some extra divergence state tracking variable or something), though it also requires some rudimentary heuristic to compute if a pattern is irrefutable in HIR, since that's currently the responsibility of THIR pattern analysis.
| @@ -21,9 +21,13 @@ fn d() { | |||
| } | |||
|
|
|||
| fn e() { | |||
| // Here the compiler fails to figure out that the `println` is dead. | |||
There was a problem hiding this comment.
Funny that this wasn't a FIXME, but it's obviously a bug.
WaffleLapkin
approved these changes
Dec 25, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#134525 (Arbitrary self types v2: unstable doc updates.) - rust-lang#134735 (Consider arm to diverge if guard diverges) - rust-lang#134741 (Actually print all the relevant parts of a coroutine in verbose mode) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2024
Rollup merge of rust-lang#134735 - compiler-errors:arm-diverges, r=WaffleLapkin Consider arm to diverge if guard diverges This is not a fix for rust-lang#134734, but I discovered it when I was gauging how difficult it would be to fix that. It does fix a really old test though :> r? `@WaffleLapkin` or reassign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a fix for #134734, but I discovered it when I was gauging how difficult it would be to fix that. It does fix a really old test though :>
r? @WaffleLapkin or reassign