core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets #134689
+106
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
RalfJung
force-pushed
the
ptr-swap-test
branch
from
71fbca1 to
313c4bc
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
approved these changes
Dec 23, 2024
…dd offsets in the type
RalfJung
force-pushed
the
ptr-swap-test
branch
from
313c4bc to
af1c8da
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
|
Somehow this does not show up in the queue? |
|
@bors r=oli-obk |
|
💡 This pull request was already approved, no need to approve it again.
|
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134638 (Fix effect predicates from item bounds in old solver) - rust-lang#134662 (Fix safety docs for `dyn Any + Send {+ Sync}`) - rust-lang#134689 (core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets) - rust-lang#134699 (Belay new reviews for workingjubilee) - rust-lang#134701 (Correctly note item kind in `NonConstFunctionCall` error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup merge of rust-lang#134689 - RalfJung:ptr-swap-test, r=oli-obk core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets Ensure that the pointer gets swapped correctly even if it is not stored at an aligned offset. This rules out implementations that copy things in a `usize` loop -- so our implementation needs to be adjusted to avoid such a loop when running in const context. Part of rust-lang#133668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the pointer gets swapped correctly even if it is not stored at an aligned offset. This rules out implementations that copy things in a
usizeloop -- so our implementation needs to be adjusted to avoid such a loop when running in const context.Part of #133668