Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update config file path in platform-support/wasm32-wasip1-threads.md #127236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iawia002
Copy link
Contributor

@iawia002 iawia002 commented Jul 2, 2024

The config content described in the Building the target section should be the configuration used for building Rust itself:

rust/config.example.toml

Lines 845 to 848 in 7d97c59

# The root location of the `wasm32-wasip1` sysroot. Only used for WASI
# related targets. Make sure to create a `[target.wasm32-wasip1]`
# section and move this field there (or equivalent for the target being built).
#wasi-root = <none> (path)

I believe this is different from Cargo's configuration. There seems to be some misunderstanding in the discussion here: #112922 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@GuillaumeGomez
Copy link
Member

r? Nilstrieb

@rustbot rustbot assigned Nilstrieb and unassigned GuillaumeGomez Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants