Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor : fixes for ratoml module #17483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alibektas
Copy link
Member

@alibektas alibektas commented Jun 23, 2024

This is a follow-up PR to #17058.

  • Parse errors are reflected as such by defining a new variant called ConfigError::ParseError
  • Amend config::ConfigChange::apply_change.
  • User config can be detected once again.
  • New error collection has been added to store config level agnostic errors.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2024
@alibektas
Copy link
Member Author

// FIXME: This should be an error
[cargo.sysroot]
non-table = "expected"

I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys.

@alibektas alibektas force-pushed the ratoml/fixes branch 2 times, most recently from 91d05c3 to c81594d Compare June 23, 2024 19:42
- Parse errors are reflected as such by defining a new variant called `ConfigError::ParseError`
- Amend `config::ConfigChange::apply_change`.
- User config can be detected once again.
- New error collection has been added to store config level agnostic errors.
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2024
@bors
Copy link
Collaborator

bors commented Jun 24, 2024

☔ The latest upstream changes (presumably #17488) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member

Veykril commented Jul 1, 2024

// FIXME: This should be an error
[cargo.sysroot]
non-table = "expected"

I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys.

Sprry forgot to reply to this. the error here is that sysroot isn't a table config, so the the non-table key being used here should error

@alibektas alibektas mentioned this pull request Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants