-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor : fixes for ratoml module #17483
base: master
Are you sure you want to change the base?
Conversation
rust-analyzer/crates/rust-analyzer/src/config.rs Lines 3610 to 3612 in bd9758b
I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys. |
91d05c3
to
c81594d
Compare
- Parse errors are reflected as such by defining a new variant called `ConfigError::ParseError` - Amend `config::ConfigChange::apply_change`. - User config can be detected once again. - New error collection has been added to store config level agnostic errors.
☔ The latest upstream changes (presumably #17488) made this pull request unmergeable. Please resolve the merge conflicts. |
Sprry forgot to reply to this. the error here is that |
This is a follow-up PR to #17058.
ConfigError::ParseError
config::ConfigChange::apply_change
.