Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a key for private registries #1476

Closed
wants to merge 1 commit into from

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Aug 22, 2021

Tried to build a crate for private repo and it works fine. The fixes actually looks really awkward due to weird git2 interface, would love to hear any comments how to make it more readable.

Related PR in rustwide: rust-lang/rustwide#65
And a version update for crates-index-diff: Byron/crates-index-diff-rs#11

@jyn514
Copy link
Member

jyn514 commented Oct 27, 2021

Marking this as blocked on rust-lang/rustwide#65.

@jyn514 jyn514 added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Oct 27, 2021
@gregvirgin
Copy link
Contributor

Raising here as in rust-lang/rustwide#65, cloudsmith.io requires .git-credentials and won't support SSH keys.

@gregvirgin
Copy link
Contributor

@l4l what private repo are you using?

@l4l
Copy link
Contributor Author

l4l commented Apr 7, 2022

I've been using self-hosted meuse quite some time ago. Current version of rustdoc supports only http auth (e.g http://login:password@my-server). Git credentials could be added separately and perhaps unrelated to this PR.

@l4l
Copy link
Contributor Author

l4l commented Apr 30, 2023

Although the blocked-by PR has been merged to rustwide I missed time slot for finishing this one before the git crate for crates-index-diff has been changed: Byron/crates-index-diff-rs@4cedf27. Currently it is using gix which if (I understand correctly)[https://github.com/Byron/gitoxide/issues/106) makes this patch obsolete because now keys in ~/.ssh could be used.

@l4l l4l closed this Apr 30, 2023
@l4l l4l deleted the registry-key branch April 30, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants