test: migrate patch, pkgid, proc_macro and progress to snapbox #14181
+715
−641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
eth3lbert
force-pushed
the
snapbox-p
branch
2 times, most recently
from
2ea54b6
to
3c545a2
Compare
eth3lbert
commented
Jul 3, 2024
epage
reviewed
Jul 5, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
eth3lbert
added a commit
to eth3lbert/cargo
that referenced
this pull request
Jul 5, 2024
This is partial revert of #rust-lang#14185 (fd8a91d) People are unlikely to see these comments when updating snapshots. Although the changes made in that commit are valid, for the same reason mentioned in the comment rust-lang#14181 (comment), "People are unlikely to see these comments when updating snapshots". Therefore, it would be better to revert these parts.
eth3lbert
added a commit
to eth3lbert/cargo
that referenced
this pull request
Jul 5, 2024
This is partial revert of rust-lang#14185 (2706247) People are unlikely to see these comments when updating snapshots. Although the changes made in that commit are valid, for the same reason mentioned in the comment rust-lang#14181 (comment), "People are unlikely to see these comments when updating snapshots". Therefore, it would be better to revert these parts.
eth3lbert
added a commit
to eth3lbert/cargo
that referenced
this pull request
Jul 5, 2024
This is partial revert of rust-lang#14185 (2706247) Although the changes made in that commit are valid, for the same reason mentioned in the comment rust-lang#14181 (comment), "People are unlikely to see these comments when updating snapshots". Therefore, it would be better to revert these parts.
bors
added a commit
that referenced
this pull request
Jul 5, 2024
…r=weihanglo fix(test): Restore `does_not_contain` for check This is partial revert of #14185 (2706247) Although the changes made in that commit are valid, for the same reason mentioned in the comment #14181 (comment), "People are unlikely to see these comments when updating snapshots". Therefore, it would be better to revert these parts. --- Let me know if anything's missing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Part of #14039.
Migrate following to snapbox:
tests/testsuite/patch.rstests/testsuite/pkgid.rstests/testsuite/proc_macro.rstests/testsuite/progress.rs