-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make no_std compatible #33
Conversation
@chifflier, would you like me to keep this PR up to date by rebasing or merging? |
Hi, |
I'm not @simpsoneric, but I managed to rebase this PR to make v0.10.0 build for Unfortunately, nom 7 broke |
@dne, thanks for taking the time to update this. Last week I started the update, but also ran into the nom7 Does it make more sense to let the changes to https://github.com/dne/nom/commits/7.0-no_std get merged to upstream nom before rebasing this? (Or just create a new PR based on your branch, no preferences here). |
Well, the necessary changes are already in nom's master branch; it's only a release that's missing. I posted a comment in rust-bakery/nom#1371 asking about that. |
@simpsoneric any chance of rebasing this again please, now that nom does have support for |
@ball-hayden, funny timing. I haven't looked at this in almost two years and some problems with syn 2.0 just came up today for me as well. I just did a quick look through your #51. Looks like you've got it updated, thanks! Feel free to go forward with it. |
Sorry! I thought I'd have a look to see how hard it would be and got carried away 😆 |
This PR is a WIP for making the crate
no_std
compatible.I would like to use nom-derive in a no_std context, and have the following attempt below.
cargo test
results as the current masterI'm not sure of the larger context for how you'd like the crate to operate. Thought I'd pass along the "request for feature".