-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the instructions for mastodon initialization #5125
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
User->>System: Create account
System->>User: Display account creation confirmation
User->>System: Approve account (Step 3)
System->>User: Account approved notification
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (4)
apps/mastodon/metadata/description.md (4)
15-18
: Approve new step and suggest consistent formattingThe addition of step 3 for approving the account is valuable information for users. However, the formatting of the command examples could be more consistent.
Consider applying this change for consistent formatting:
2. Fill in your credentials (some_username,[email protected]), then run the command: ``` sudo docker exec -it -w /app/www mastodon bin/tootctl accounts create some_username --email [email protected] --confirmed --role Owner ``` 3. You will need to approve the account before using it - ``` - sudo docker exec -it -w /app/www mastodon bin/tootctl accounts modify some_username --approve - ``` + ``` + sudo docker exec -it -w /app/www mastodon bin/tootctl accounts modify some_username --approve + ```🧰 Tools
🪛 Markdownlint
16-16: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
50-50
: Consider rephrasing for clarityThe current phrasing "This results in a rich app ecosystem with a lot of choices!" could be improved for clarity and conciseness.
Consider applying this change:
-Mastodon acts as an OAuth2 provider, so 3rd party apps can use the REST and Streaming APIs. This results in a rich app ecosystem with a lot of choices! +Mastodon acts as an OAuth2 provider, allowing 3rd party apps to use the REST and Streaming APIs. This fosters a diverse and rich app ecosystem.🧰 Tools
🪛 LanguageTool
[style] ~50-~50: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...is results in a rich app ecosystem with a lot of choices!(A_LOT_OF)
[style] ~50-~50: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 1963 characters long)
Context: ...rich app ecosystem with a lot of choices!(EN_EXCESSIVE_EXCLAMATION)
11-11
: Use proper Markdown link syntaxInstead of using a bare URL, it's better to use proper Markdown link syntax for improved readability and maintainability.
Apply this change:
-- Must be on Tipi Version **1.4.0** for the expose app to work! +- Must be on Tipi Version [**1.4.0**](https://github.com/runtipi/runtipi/releases/tag/v1.4.0) for the expose app to work!🧰 Tools
🪛 Markdownlint
11-11: null
Bare URL used(MD034, no-bare-urls)
12-18
: Add language specification to fenced code blocksFor improved syntax highlighting and readability, it's recommended to specify the language for fenced code blocks.
Apply these changes:
2. Fill in your credentials (some_username,[email protected]), then run the command: - ``` + ```bash sudo docker exec -it -w /app/www mastodon bin/tootctl accounts create some_username --email [email protected] --confirmed --role Owner ``` 3. You will need to approve the account before using it - ``` + ```bash sudo docker exec -it -w /app/www mastodon bin/tootctl accounts modify some_username --approve ```🧰 Tools
🪛 Markdownlint
12-12: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
16-16: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- apps/mastodon/metadata/description.md (2 hunks)
🧰 Additional context used
🪛 Markdownlint
apps/mastodon/metadata/description.md
11-11: null
Bare URL used(MD034, no-bare-urls)
12-12: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
16-16: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
🪛 LanguageTool
apps/mastodon/metadata/description.md
[style] ~50-~50: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...is results in a rich app ecosystem with a lot of choices!(A_LOT_OF)
[style] ~50-~50: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 1963 characters long)
Context: ...rich app ecosystem with a lot of choices!(EN_EXCESSIVE_EXCLAMATION)
@@ -8,10 +8,14 @@ | |||
|
|||
## Initial User Setup | |||
1. SSH into your Tipi Server | |||
2. Fill in your credentials (some_username,[email protected], some_very_good_password), then run the command: | |||
2. Fill in your credentials (some_username,[email protected]), then run the command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in "Local Domain Variable" heading
There's a typo in the heading "Local Domain Varibale". It should be corrected to "Local Domain Variable".
Apply this change:
-#### Local Domain Varibale
+#### Local Domain Variable
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
2. Fill in your credentials (some_username,[email protected]), then run the command: | |
#### Local Domain Variable |
🧰 Tools
🪛 Markdownlint
11-11: null
Bare URL used(MD034, no-bare-urls)
This minor PR corrects the needed docs for initializing mastodon instance by the user. You will need to approve the first account using
tootctl
too.Summary by CodeRabbit