add(app): AnythingLLM #4430
add(app): AnythingLLM #4430
Conversation
WalkthroughThe recent updates introduce essential configuration and deployment files for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Oh yeah those fields. I'll wait to see if someone has any suggestions before choosing myself. |
Hello @cori as I seen it's linux timestamp with "000" at end. :) |
|
I got the dates answer i was looking for once the docs were updated (and it pretty much matched my instincts anyway). I'm running into one problem while testing this app - during install it tries to create a SQLite DB in the app-data folder and can't access it on first start - the container goes into a restart loop that only resolves on app restart, which isn't a great first-install experience. I'm going to try to work that out before undrafting this. |
|
@coderabbitai review I think this is ready, and i think an incremental CodeRabbitting will be sufficient to catch any ... insufficiencies. This last issue was an interesting little problem; AnythingLLM's Prisma client needed access to the I added a phantom directory in that location in the app's config (by including an explanatory README) and Tipi / Docker then created the location earlier in the process and it was there when Prisma needed it. Not sure if this is a known pattern - I knew about the |
|
@cori: The approach you've taken by adding a README file to ensure the creation of the Great job in resolving this issue! It looks like the solution you've implemented should provide a better first-install experience for users. Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Searching for the README file added in the PR to understand the changes made by the user.
fd README --exec cat
Length of output: 66374 Actions performedReview triggered.
|
|
lol that wasn’t really why I wrote that comment or asked CR for a re-review but I’m glad it approves. |
this was a plain copy-paste from Mintplex's source, but sure, the comment's fair.
and update image tag
the storage path seems unavailable on first start and the container throws and error message but exits with exit code 0. A manual restart fixes and the source docker-compose file has threstart set to `always`
Placing a file in the app's destination volume for the SQLite database the app needs to create appears to force Tipi to materialize the folder at a point in the process where AnythingLLM's Prisma client could access it on first run. Without this, the Prisma client tried to create the file at a as-yet-nonexistant path and failed. Tipi subsequently created the volume location (b/c it was there on the host after Prisma failed) and a simple app restart allowed Prisma to run its migrations on the file it could now create. steps: - attempt an init service - try getting rid of the env var for the storage and stop depending on the init service - try an init service again; removing the env var did nothing - materialize the file? - remove the volume init service - try nesting the storage volume inside data - along with precreating the file? or maybe i won't need that? - try without preseeding the file - what if we materialize a different file? - non-debugging `restart` flag
cori
force-pushed
the
app/AnythingLLM
branch
from
0a36403 to
15d5cba
Compare
|
given the new policy for PRs I will not be grumpy if y'all just close this, but i'll leave it here in case someone's motivated. |
Turns out i could have just added a couple of commits to the original PR.
After much faffing I decided trying to get AnythingLLM all the way set up from install with no manual steps was going to be super-hacky, so This Is Fine ™️
Maybe the rumored hooks will offer a solution to the challenges i ran into here.
Summary by CodeRabbit