Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] The Stronghold of Security #312

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

src52
Copy link
Contributor

@src52 src52 commented May 13, 2021

This draft adds support for the Stronghold of Security.

Features of this change include:

  • The ability to interact with the stronghold doors, and receive quiz questions to answer. (After 3 incorrect attempts, you are teleported through)
  • A quiz file that loads the quiz data.
  • The vast majority of NPC spawns for the four levels of the dungeon (Some are missing in the Catacomb of Famine).
  • Proper rewards for completing each level of the dungeon (Money, emotes, and the ability to use the portals to jump to the treasure room).
  • All interactable objects function as expected, such as ladders, escape ropes, portals, etc.
  • Proper sounds, animations and messages.
  • Progress is saved to the Player's character file.
  • You can choose which style of boots you want at the end of the dungeon. Swapping boots, and replacement boots if they're lost is also supported.
  • Pit of Pestilence map file was added to the cache from the 455 revision, with their proper xteas.
  • You can search the dead explorer's body and find the stronghold book.
  • You can read the stronghold notes book.

Aspects not yet implemented are:

  • There are some question responses without official dialogue yet, I'm still working on those.
  • Some NPCs are missing from the Catacomb of Famine.
  • Supplying a list of doors that are exempt from questions. (Doors that lead into a room with no monsters don't have questions, the player can just teleport through.)
  • Ensuring the player doesn't receive two identical questions in a row.
  • The Barbarian Village map that allows the player to enter the dungeon isn't in the cache, so players cannot access it through regular means.

In addition to these changes, this commit also:

  • Allows dialogues longer than 4 lines to wrap into a new dialogue tree.
  • Replaces the traditional login screen music with Scape Scared, since this is a Halloween server.

Spencer Carlson added 2 commits May 12, 2021 17:10
Stronghold of Security plugins:
Door plugin that handles travelling through the stronghold doors
Reward plugin that handles receiving rewards
Quiz plugin that handles the quiz questions and answers
Objects plugin that handles interaction with objects in the dungeon (such as portals, ladders, escape ropes)

NPC keys for all NPCs in the Stronghold.
NPC Spawns for all of the NPCs in the Stronghold.
Travel Locations for the various levels of the dungeon.
Pit of Pestilence map data from Revision #455 to the cache, and xteas folder.
Music tracks for the Stronghold levels

Modify:
Change facepalm emote name to Slap Head
Dialogue plugin to give dialogues the ability to wrap into new ones if the text is more than 4 lines.
waitForPathing() method with optional boolean to ignore interaction distance requirement.

Fix:
Player's music player button state not loading correctly upon login
Unnecessary debug messages.
@src52 src52 changed the title [DRAFT [DRAFT] The Stronghold of Security May 13, 2021
src added 3 commits May 13, 2021 10:30
Copy link
Member

@Tynarus Tynarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review, please use underscore_case for config keys, anything with a prefix rs: or x:

data/config/npcs/dungeons/stronghold-of-security.json Outdated Show resolved Hide resolved
Spencer Carlson added 2 commits May 14, 2021 12:19
Casing on item and NPC definitions to match the standard.
Spencer Carlson added 2 commits May 20, 2021 18:43
A basic book system to display book information on an interface from json5
Stronghold of security book
Stronghold of security book item key

Fix:
Player emotes not closing interfaces.

Modify:
Movement radius of all monsters in the Stronghold of Security.
@src52
Copy link
Contributor Author

src52 commented May 21, 2021

I still need to work on the books a bit more, definitely.

Right now it's only really applied for one case. But I want to make it more generic so that any BookData object can take the methods and use them to display their info easily.

src added 5 commits May 22, 2021 17:45
A bug where books with long sections wouldn't display all pages.
A typo in a mining message

Add:
A method to find BookData from book ID.
Book data for the Construction guide book
Book data for the pie recipe book

Modify:
The book system to load all books from the books directory
The book system to be more generic, and much simpler in certain areas. Removed lots of unnecessary duplicate calls.

Rename:
stronghold-of-security-book.plugin to books.plugin
loadStrongholdOfSecurityBook() to loadBookData()
More Stronghold of security questions and responses.
@src52 src52 requested a review from Tynarus May 27, 2021 00:13
@Jameskmonger Jameskmonger added the pre-tick PR's made before the tick based system was introduced label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-tick PR's made before the tick based system was introduced work in progress Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants