Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container option in waitjob read namespace pod log #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RupakVeerla
Copy link

@RupakVeerla RupakVeerla commented Sep 29, 2022

Resolves issue #133

  • If there are multiple containers in a pod, wait job fails to get logs, so this change will choose a specific container to get logs from.
  • It gets the container name from environment variable.
  • If no container is specified, it will choose the default container to get the log.

@ltamaster
Copy link
Contributor

Hi @RupakVeerla ,

Can we add the container field as an optional value, to no break existing configuration
thanks
Luis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants