Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont log GitHub app token in logs #4667

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: dont log GitHub app token in logs #4667

merged 1 commit into from
Sep 6, 2024

Conversation

dobby-dobster
Copy link
Contributor

@dobby-dobster dobby-dobster commented Jun 15, 2024 •
edited by nitrocode
Loading

what

Change the log line to prevent logging the GitHub App token in logs.

why

tests

Confirmed Atlantis continues to successfully start.

references

@dobby-dobster dobby-dobster requested review from a team as code owners June 15, 2024 20:37
@dobby-dobster dobby-dobster requested review from jamengual, nitrocode and X-Guardian and removed request for a team June 15, 2024 20:37
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 15, 2024
@chenrui333 chenrui333 changed the title feat: Dont log GitHub app token in logs fix: dont log GitHub app token in logs Jun 15, 2024
@jamengual
Copy link
Contributor

thanks @dobby-dobster for the contribution

@jamengual jamengual merged commit cb5be4a into runatlantis:main Sep 6, 2024
30 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode nitrocode approved these changes

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
go Pull requests that update Go code security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git credentials are exposed in atlantis logs
4 participants
@dobby-dobster @jamengual @nitrocode @tobaker