Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Right-click menu insert image option doesn't work #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Right-click menu insert image option doesn't work #414

wants to merge 1 commit into from

Conversation

ZhengIce
Copy link
Collaborator

fix：

  • The problem of the "insert image" option in the right-click menu not working.

zyc9012
zyc9012 requested changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@zyc9012 zyc9012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the into a separate component as SheetOverlay is already bloated.

Let's use class instead of id for the and also update showImgChooser function to find the under workbookContainer. Otherwise, it won't work with multi-instance usage.

@zyc9012 zyc9012 force-pushed the master branch 3 times, most recently from 471416d to 829cacb Compare April 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyc9012 zyc9012 zyc9012 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhengIce @zyc9012