Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update formula after deleting rows or columns #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Update formula after deleting rows or columns #393

wants to merge 1 commit into from

Conversation

ZhengIce
Copy link
Collaborator

@ZhengIce ZhengIce commented Jun 2, 2023

fix:

  • When deleting rows or columns, the value of the reference formula cell is not updated

zyc9012
zyc9012 reviewed Jun 25, 2023
View reviewed changes
packages/core/src/modules/rowcol.ts
@@ -2052,6 +2077,9 @@ export function deleteRowCol(
file.data = d;
file.config = cfg;
file.calcChain = newCalcChain;
// 删除行列后，更新公式所在单元格的值
updateFormulaDeletingRowCol(ctx, newCalcChain);
Copy link
Contributor

@zyc9012 zyc9012 Jun 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use jfrefreshgrid?

@zyc9012 zyc9012 force-pushed the master branch 3 times, most recently from 471416d to 829cacb Compare April 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyc9012 zyc9012 zyc9012 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhengIce @zyc9012