Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bundler as a runtime dependency #65

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

Manfred
Copy link
Collaborator

@Manfred Manfred commented Nov 23, 2019

By adding bundler as a runtime dependency we can require Bundler without having to bundle exec in the target application. This makes perf_check / work instead of bundle exec perf_check /. It's useful for when you want to use PerfCheck without adding it to the bundle of the target application.

@Manfred Manfred requested a review from sudara November 23, 2019 09:14
@Manfred
Copy link
Collaborator Author

Manfred commented Nov 23, 2019

It seems we are stuck in a catch-22. We want to use --frozen to prevent Bundler from changing the lockfile, but that also writes bundler config and causes issues when trying do subsequent bundle installs. I'm going to think about this for a while.

@Manfred
Copy link
Collaborator Author

Manfred commented Nov 27, 2019

Because PerfCheck now requires bundler I had to re-create Gemfile.lock in the test application bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant