Tweak dependency handling #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hadley
commented
Feb 13, 2024
hadley
commented
- Bump required version of DBI. Fixes No function correspond to methods exports for dbAppendTableArrow failing Docker install #178.
- Message if dbplyr is old. Fixes Error when using compute() to create a new table in a schema. Same code using connections created with dbConnect() works. #179 (as much as possible)
lionel-
approved these changes
Feb 14, 2024
Comment on lines
+102
to
+104
| cnd_startup <- class(catch_cnd(packageStartupMessage("hi"))) | ||
| cnd_startup <- c(cnd_startup[1:2], "rlang_message", cnd_startup[-(1:2)]) | ||
| expect_equal(cnd_dplyr, cnd_startup) |
There was a problem hiding this comment.
This seems a bit brittle. Maybe do skip_on_cran() before?
Comment on lines
9
to
+14
| #' @import rlang | ||
| NULL | ||
|
|
||
| ## usethis namespace: start | ||
| #' @importFrom utils packageVersion | ||
| ## usethis namespace: end |
There was a problem hiding this comment.
Might be worth cleaning up the imports in a follow up commit, just for future you
There was a problem hiding this comment.
You mean the other imports?
There was a problem hiding this comment.
yea just moving them to the usethis managed section is all i meant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.