Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dplyr code #583

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Simplify dplyr code #583

merged 4 commits into from
Dec 4, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 3, 2024

Summary

Potentially seeking performance improvements.

@rich-iannone
Copy link
Member

This is great @olivroy ! We will review shortly. And if you're interested, please add yourself as a contributor in DESCRIPTION.

yjunechoe
yjunechoe previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@yjunechoe yjunechoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Refactoring just the code we know will directly improve performance is a very nice problem scope. LGTM!

rich-iannone
rich-iannone previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@rich-iannone
Copy link
Member

@olivroy we've both accepted the PR but, again, feel free to add yourself to the author list (we can merge after that).

@olivroy olivroy dismissed stale reviews from rich-iannone and yjunechoe via 3ee55a4 December 4, 2024 21:29
@olivroy
Copy link
Contributor Author

olivroy commented Dec 4, 2024

Thanks!

@rich-iannone rich-iannone self-requested a review December 4, 2024 22:03
@rich-iannone rich-iannone merged commit 29ad2ec into rstudio:main Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

@yjunechoe yjunechoe yjunechoe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivroy @rich-iannone @yjunechoe