Use testthat 3 + remove deprecated features

[olivroy]

Summary

Turns out this was much more work than I imagined

• Convert to testthat 3
  • Get rid of expect_equivalent() (various solutions were needed here, such as creating expect_equal_unlist() that is equivalent to expect_equal(unlist(object), expected), use ignore_attr
  • Use a snapshot test to capture many warnings
  • Change order of operations to account for breaking change in testthat 3.1
  • Use expect_s3_class() and expect_type() instead of expect_is()
• Use tidyselect::all_of() instead of superseded one_of()
• Get rid of a partial match issue
• Use parallel tests
• Use expect_no_*() instead of expect_*(regexp = NA)
• Use testthat::test_path() to facilitate running tests interactively.
• Avoid dplyr superseded function
• Remove rlang deprecation warning

Also a reminder that to unlock the coverage action, you will have to add a Codecov token

Other minor cleanup

Checklist

• I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• I have added testthat unit tests to tests/testthat for any new functionality.

[olivroy]

@rich-iannone sorry for the many follow-up commits. Now ready for review!

[rich-iannone]

This is great @olivroy ! Thanks so much for taking the time for all these fixes :)

@yjunechoe I also invited you to take a look at the changes if you're up for it.

[rich-iannone]

LGTM and thanks so much!

[yjunechoe]

Wonderful! The deprecation warnings were a headache to track down, so I'm very happy to see them resolved

All tests continue to pass when I test on my end, so LGTM as well!

[rich-iannone]

@olivroy it seems like the empty commit trick didn't fix the hanging check of the branch status. Maybe we wait another day for this to (hopefully) update?

[rich-iannone]

I don't have a way through the GitHub UI. And I tried through GH Mobile but it's the same hanging state. I might work itself out in time. Worst case scenario is you make another PR with the same changes.

[rich-iannone]

That worked!

[rich-iannone]

Alright! After CI runs, I'll merge!

[olivroy]

I just did

gert::git_reset_soft("HEAD~3")
gert::git_commit_all("commit to unstale branch")
gert::git_push(force = TRUE)

and it worked! guess GitHub didn't like removing a commit, but doesn't mind combining into many. The commits are less informative now, but it is fine since you both reviewed it already!)

[rich-iannone]

Thanks again @olivroy for modernizing the codebase. I will add a CodeCov token soon!